Add utilities to test persistence#300
Merged
ValuedMammal merged 4 commits intobitcoindevkit:masterfrom Sep 5, 2025
Merged
Conversation
Added the following functions:- - `persist_wallet_changeset`: tests if each field of wallet ChangeSet is persisted. - `persist_multiple_wallet_changesets`: tests if multiple wallets can be persisted in a single file. - `persist_network`: tests if network is persisted - `persist_keychains`: tests if descriptors are persisted - `persist_single_keychain`: tests if descriptor in single keychain wallet is persisted.
Used persist_test_utils to test WalletPersister impl of file_store and rusqlite.
Otherwise ci fails
110CodingP
force-pushed
the
add_persist_test_utils
branch
from
621ad7b to
abcf868
Compare
Pull Request Test Coverage Report for Build 17176091820Details
💛 - Coveralls |
Collaborator
|
Looks good overall. I haven't noticed any issues 👍 |
3 tasks
ValuedMammal
added a commit
that referenced
this pull request
Sep 25, 2025
b642284 refactor: remove bdk_testenv dependency (codingp110) 7a5b644 docs: document persist_test_utils module (codingp110) 5d9a95c test: use utils to test file_store and rusqlite (codingp110) 79586e8 feat: add utilities to test persistence of wallet (codingp110) Pull request description: Backports #300 adding the `persist_test_utils` module to the `release/2.2` branch. ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `just p` before pushing ACKs for top commit: oleonardolima: cACK b642284 notmandatory: ACK b642284 Tree-SHA512: ca482cb61ed9a9e98a18fa35ce534d969b26eb7f71141d66105362d64ba8e18c4664eb5e14e38f61e1c0750d801391a821706ba7141db65a317d9ac22b546316
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added some basic functions to test
WalletPersisterimpl. Fixes #14 and might help with #234 .Changelog notice
Checklists
All Submissions:
just pbefore pushingNew Features: