Update installation and interface guide of CLI#109
Update installation and interface guide of CLI#109notmandatory merged 1 commit intobitcoindevkit:masterfrom
Conversation
✅ Deploy Preview for awesome-golick-685c88 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
a00ce1e to
13a525a
Compare
notmandatory
left a comment
There was a problem hiding this comment.
I left a few small suggestions but overall this looks good. Thanks for the overdue refresh for this section.
13a525a to
03c8212
Compare
rajarshimaitra
left a comment
There was a problem hiding this comment.
ACK 03c8212
Thanks for covering this.. This is compatible with remaining of the pending updates in bdk-cli too.. So its good to go..
Just one small thing that we should also update with this..
Line 20: At the time of writing, the project requires cargo >= 1.46.0, which is our minimum supported rust version (MSRV) as of July 2021. If you have an older version installed with rustup.rs, you can upgrade it with
rustup update.
This can be updated now.. Our MSRV in v0.5.0 is 1.56.
03c8212 to
bc36ad1
Compare
|
@rajarshimaitra, changed the MSRV to 1.56.0 as recommended |
bc36ad1 to
d9b4132
Compare
rajarshimaitra
left a comment
There was a problem hiding this comment.
Thanks for the update.. This looks good to me now.. Just few more nits here and there..
Update the instructions in the guide to follow the latest version of the CLI. Remove some information duplication and typos.
d9b4132 to
ffcab9e
Compare
notmandatory
left a comment
There was a problem hiding this comment.
ACK ffcab9e
Looks good to me.
Update the instructions in the guide to follow the latest version of the CLI. Remove some information duplication and typos.
@notmandatory, I removed the language specification on the bash command outputs because it will try to highlight anything in the output that looks like code. Like the angle brackets in the

signoutput below: