Update the playground to the latest bdk-cli #118
Merged
afilini merged 6 commits intobitcoindevkit:masterfrom Oct 7, 2022
Merged
Update the playground to the latest bdk-cli #118afilini merged 6 commits intobitcoindevkit:masterfrom
afilini merged 6 commits intobitcoindevkit:masterfrom
Conversation
✅ Deploy Preview for awesome-golick-685c88 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
26 tasks
danielabrozzoni
force-pushed
the
repl_update
branch
from
bcb8525 to
9f0fdea
Compare
This was referenced Sep 14, 2022
danielabrozzoni
force-pushed
the
repl_update
branch
from
9f0fdea to
1723f50
Compare
rajarshimaitra
added a commit
to bitcoindevkit/bdk-cli
that referenced
this pull request
Sep 26, 2022
731dc74 Add wasm build in CI (Daniela Brozzoni) b3469b4 Add wasm support (Daniela Brozzoni) Pull request description: ### Description This PR adds a module to bdk-cli that exposes some structures/functions to WASM. You can see it in use here: bitcoindevkit/bitcoindevkit.org#118 ### Notes to the reviewers Based on #116 ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk-cli/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing #### New Features: * [ ] I've added tests for the new feature * [ ] I've added docs for the new feature * [x] I've updated `CHANGELOG.md` #### Bugfixes: * [ ] This pull request breaks the existing API * [ ] I've added tests to reproduce the issue which are now passing * [ ] I'm linking the issue being fixed by this PR ACKs for top commit: rajarshimaitra: ACK 731dc74 Tree-SHA512: 69011ab6cb421f7e6f7dd000f9eaf5581428b2288358e31ffaec4425996951443fa2fc79f99db7de9c030d6a3fda57d25eee11564cf2fab9c745da593324f763
danielabrozzoni
force-pushed
the
repl_update
branch
2 times, most recently
from
da2aaf2 to
d2d06d3
Compare
afilini
reviewed
Oct 5, 2022
Member
|
Also I think currently your submodule is pointed to a local path, it should be changed to the https git url |
Member
Author
No, it's a git submodule, so the local path should be ok |
danielabrozzoni
force-pushed
the
repl_update
branch
2 times, most recently
from
df5da41 to
8671c03
Compare
afilini
approved these changes
Oct 6, 2022
Member
|
Actually the wasm file is like 25mb, was it built in release mode? |
Remove all the rust code from the playground, instead use the bdk-cli "wasm" module. Update the js code to use bdk-cli instead of the utilities that were previously under src/ Update the README with instructions on how to compile the playground Fixes bitcoindevkit#111
danielabrozzoni
force-pushed
the
repl_update
branch
from
8671c03 to
df7b325
Compare
Before, failing to create the wallet instance wouldn't report the error back to the caller, which would usually go on and call methods on inst, casuing null pointer exceptions. You can try this by entering the current playground and inserting a descriptor with a mismatched checksum: the error would be logged in the console, but a weird error would be presented to the user.
The stop button wouldn't work as it was calling `currentWallet.free()`, which is not defined. Instead, assigning null to currentWallet and let the garbage collector do its thing.
danielabrozzoni
force-pushed
the
repl_update
branch
from
df7b325 to
c3c4ddc
Compare
Member
Author
|
Sorry, it's 6MB now |
afilini
approved these changes
Oct 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This needs bitcoindevkit/bdk-cli#116 & bitcoindevkit/bdk-cli#117 to be merged first
Everything under
docs/.vuepressis auto-generated, so you don't have to review it :)