Skip to content

Update docs links, fix broken code #139

Merged
notmandatory merged 2 commits intobitcoindevkit:masterfrom
wilfredallyn:update-docs
Feb 27, 2023
Merged

Update docs links, fix broken code #139
notmandatory merged 2 commits intobitcoindevkit:masterfrom
wilfredallyn:update-docs

Conversation

@wilfredallyn
Copy link
Copy Markdown
Contributor

  • Updated documentation links to point to the latest version
  • Fixed code in Hello World tutorial to handle balance struct instead of u64
  • Running Spending Policy tutorial Step 1a now produces this error
$ bdk-cli wallet -w carol -d $CAROL_DESCRIPTOR get_new_address
[2023-02-13T11:08:03Z ERROR bdk_cli] Descriptor(Miniscript(TypeCheck("fragment «thresh(3,pk([5f769577/84'/1'/0'/0]tpubDFBt.../*),s:pk([ef28b7c5/84'/1'/0'/0]tpubDEx.../*),s:pk(tprv8Z.../84'/1'/0'/0/*),sdv:older(2))» sub-fragment 3 is not a unit (does not put exactly 1 on the stack given a satisfying input)")))

I fixed the problem by re-compiling the miniscript policy using the playground and updating the descriptors (sdv:older(2) -> snl:older(2))

@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 13, 2023

Deploy Preview for awesome-golick-685c88 ready!

Name Link
🔨 Latest commit d1c9e0e
🔍 Latest deploy log https://app.netlify.com/sites/awesome-golick-685c88/deploys/63ea9aa5b5d1980008730572
😎 Deploy Preview https://deploy-preview-139--awesome-golick-685c88.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@notmandatory
Copy link
Copy Markdown
Member

notmandatory commented Feb 13, 2023

Thanks for the fixes. I agree it makes sense to update the tutorials and other general docs to latest bdk, but for the release blog posts about older versions I'd leave those as they were pointing to the corresponding bdk releases.

@wilfredallyn
Copy link
Copy Markdown
Contributor Author

That makes sense to leave the blog posts about older versions pointing to those releases. I revised commit 1075574 to exclude those

Copy link
Copy Markdown
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d1c9e0e

@notmandatory notmandatory merged commit 6807c7b into bitcoindevkit:master Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants