Remove duplicate TXIN_BASE_WEIGHT from new_tr_keyspend#32
Merged
LLFourn merged 2 commits intobitcoindevkit:masterfrom Jan 29, 2025
Merged
Remove duplicate TXIN_BASE_WEIGHT from new_tr_keyspend#32LLFourn merged 2 commits intobitcoindevkit:masterfrom
LLFourn merged 2 commits intobitcoindevkit:masterfrom
Conversation
cygnet3
force-pushed
the
fix-new-tr-keyspend
branch
from
00cdc23 to
4262a82
Compare
cygnet3
changed the title
LLFourn
approved these changes
Jan 29, 2025
Collaborator
LLFourn
left a comment
LLFourn
left a comment
There was a problem hiding this comment.
tACK 4c9b73ed8b04a456ab10cdb9e7fa162b8a6a91b6
LLFourn
reviewed
Jan 29, 2025
| /// Create a [`Candidate`] input that spends a single taproot keyspend output. | ||
| pub fn new_tr_keyspend(value: u64) -> Self { | ||
| let weight = TXIN_BASE_WEIGHT + TR_KEYSPEND_SATISFACTION_WEIGHT; | ||
| let weight = TR_KEYSPEND_SATISFACTION_WEIGHT; |
Collaborator
There was a problem hiding this comment.
Wait did you mean to use TR_KEYSPEND_TXIN_WEIGHT.
EDIT -- oh no I see now.
Collaborator
|
I added a test. Will fix the ci in a moment. |
LLFourn
force-pushed
the
fix-new-tr-keyspend
branch
from
4262a82 to
52767a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the duplicate
TXIN_BASE_WEIGHTwhen callingCandidate::new_tr_keyspend.Closes #31