Fix: allow zero-fee transactions in LowestFee metric#35
Merged
evanlinjin merged 3 commits intobitcoindevkit:masterfrom Sep 15, 2025
Merged
Conversation
Change assertion from fee > 0 to fee >= 0 to handle valid zero-fee transactions. Add test case to verify the metric works correctly when target fee rate is zero. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
evanlinjin
force-pushed
the
fix/lowest-fee-metric-with-zero-fee
branch
2 times, most recently
from
eddfb94 to
67a8698
Compare
jp1ac4
reviewed
Sep 15, 2025
| } | ||
|
|
||
| #[test] | ||
| fn zero_fee_tx() { |
Contributor
There was a problem hiding this comment.
Not sure if it matters, but AFAICT this test produces a solution with a non-zero fee (130 sats).
Member
Author
There was a problem hiding this comment.
If it's a solution with change then it's a problem. If it's without change, it's expected as we have a long-term feerate so that greatly disincentives the solution with change.
Member
Author
There was a problem hiding this comment.
But maybe we should check that a solution with change has 0 fee.
Contributor
There was a problem hiding this comment.
Ah OK, the solution doesn't have change so that's fine. I wasn't sure if the intention of the test was to produce a transaction with zero fee.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change assertion from fee > 0 to fee >= 0 to handle valid zero-fee transactions. Add test case to verify the metric works correctly when target fee rate is zero.
Also make clippy happy and upgrade test dependencies.