Add ancestor_bump_fee to Candidate#42
Closed
aagbotemi wants to merge 2 commits intobitcoindevkit:masterfrom
Closed
Add ancestor_bump_fee to Candidate#42aagbotemi wants to merge 2 commits intobitcoindevkit:masterfrom
aagbotemi wants to merge 2 commits intobitcoindevkit:masterfrom
Conversation
evanlinjin
requested changes
Mar 30, 2026
Member
There was a problem hiding this comment.
NACK
Thanks for working on this. However, this solution is flawed.
ancestor_bump_feeis a function of the target feerate. This is incorrect asCandidateshould only have fixed properties of an UTXO.- This solution does not take ancestor overlaps into account. Please refer to #24 (comment)
Also, next time, please remember to reference pre-existing PRs addressing similar problems. This PR is essentially a competing solution to #38.
Contributor
Author
|
Thanks for the review.
Both points are valid.
I looked at #38 before opening this PR and concluded they addressed different layers. #38 operates at the transaction level with a single |
Contributor
Author
|
Closing in favor of #43 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
ancestor_bump_feefield toCandidate, allowing callers toexpress the additional fee a child transaction must pay to bring
its unconfirmed ancestors up to the target feerate.
Note to Reviewers
Cross-candidate ancestor deduplication is not handled at this layer.
Shared ancestors across candidates are counted per-candidate, which
may overcount when multiple selected candidates share an ancestor.
This is conservative (overpays, never underpays). The wallet layer
deduplicates post-selection.
Closes #24
Changelog notice
ancestor_bump_feefield toCandidatefor ancestor-aware coin selectionChecklists
All Submissions: