feat: Add absolute fee target to TargetFee#44
Merged
evanlinjin merged 1 commit intobitcoindevkit:masterfrom Apr 24, 2026
Merged
feat: Add absolute fee target to TargetFee#44evanlinjin merged 1 commit intobitcoindevkit:masterfrom
evanlinjin merged 1 commit intobitcoindevkit:masterfrom
Conversation
Add a `TargetFee::absolute` field that acts as a minimum absolute fee floor, checked independently alongside the existing feerate and replacement constraints. This supports use cases like Payjoin (BIP 78), where the receiver must not decrease the original transaction's absolute fee, and application-level policy minimums. Changes: - Add `absolute: u64` field to `TargetFee` - Add `CoinSelector::absolute_excess()` method - Integrate absolute excess into `CoinSelector::excess()` via `.min()` - Account for absolute fee in `CoinSelector::implied_fee()` - Handle absolute constraint in `LowestFee::bound()` for correct branch-and-bound behavior Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TargetFee::absolutefield as a minimum absolute fee floor, checked independently alongside the existing feerate and replacement constraintsCoinSelector::absolute_excess()method and integrates it intoexcess()via.min()so the most binding constraint winsLowestFee::bound()for correct branch-and-bound behaviorUse cases:
bdk_wallet'sTxBuilder::fee_absolute()API where users set a fee floor regardless of feerateExtracted from #38 (package context changes excluded).
Test plan
cargo test— all existing tests passcargo test --no-default-features— no_std builds passcargo clippy— clean🤖 Generated with Claude Code