Add raw_call to ElectrumApi#74
Add raw_call to ElectrumApi#74afilini merged 1 commit intobitcoindevkit:masterfrom zoedberg:raw_call
Conversation
|
Am I correct that after the latest version was yanged this is not yet released in any working crate version? |
dr-orlovsky
left a comment
dr-orlovsky
left a comment
There was a problem hiding this comment.
Post-merge review with improvement proposal
| } | ||
|
|
||
| /// Executes the requested API call returning the raw answer. | ||
| fn raw_call(&self, call: &Call) -> Result<serde_json::Value, Error>; |
There was a problem hiding this comment.
this leads to calling method like raw_call(&("method_name".to_owned(), vec![])), which is very non-rust ideomatic. Thus I propose a follow-up PR with changing function signature to raw_call(&self, method_name: &str, params: impl IntoIterator<Item=Param>).
This, however, will be a breaking change and will require a new minor version bump.
This should be part of
This is fine, we will have to do a breaking release anyway because we've recently changed the implementation of socks so we can include this as well. |
3d96644a0f7e5823b8b9bd712640ddfbb253061d Add raw_call to ElectrumApi (Zoe Faltibà)
Pull request description:
In order to give more flexibility to the users of this library I added a `raw_call` method to the `ElectrumApi` trait that will allow to call any arbitrary electrum API call.
ACKs for top commit:
afilini:
ACK 3d96644a0f7e5823b8b9bd712640ddfbb253061d
Tree-SHA512: b88ece7bd9ff8121272c3b3528430e9ccb8778661b15cce276c6f67a8797a4dbf4c52a8521191942c21e8b67ebde8187fd75ac49189440b0fbb71274974b4b41
3 participants
In order to give more flexibility to the users of this library I added a
raw_callmethod to theElectrumApitrait that will allow to call any arbitrary electrum API call.