fix: expose TLS backend choice in features#44
Conversation
vladimirfomene
left a comment
vladimirfomene
left a comment
There was a problem hiding this comment.
This looks good to me. Thanks for the contribution! Will discuss with team whether it makes sense to phase out the async-https feature.
Pull Request Test Coverage Report for Build 4518650682Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
| async = ["reqwest", "reqwest/socks"] | ||
| async-https = ["async", "reqwest/default-tls"] | ||
| async-https-native = ["async", "reqwest/native-tls"] | ||
| async-https-rustls = ["async", "reqwest/rustls"] |
There was a problem hiding this comment.
I think we're supposed to use the feature request/rustls-tls which defaults to using webpki-roots, or do you want manually set the root certs? In that case we'd need request/rustls-tls-manual-roots.
There was a problem hiding this comment.
Or can add both options:
| async-https-rustls = ["async", "reqwest/rustls"] | |
| async-https-rustls = ["async", "reqwest/rustls-tls"] | |
| async-https-rustls-manual-roots = ["async", "reqwest/rustls-tls-manual-roots"] |
| @@ -38,3 +38,5 @@ default = ["blocking", "async", "async-https"] | |||
| blocking = ["ureq", "ureq/socks-proxy"] | |||
| async = ["reqwest", "reqwest/socks"] | |||
| async-https = ["async", "reqwest/default-tls"] | |||
There was a problem hiding this comment.
I think it's OK to leave the async-https feature in for now as an option for folks who decided not to decide which TLS to use and go with the default request chooses.
elsirion
force-pushed
the
2023-03-expose-tls-backend-choice
branch
from
2d0a683 to
44f7d29
Compare
|
What's the status on this? Do I need to change anything? |
|
Sorry for the delay on this. This is good. I'm merging it. |
…hoice in features 44f7d296b391848633f48e3db67f88da38f46dea fix: expose TLS backend choice in features (elsirion) Pull request description: I left the default `async-https` feature in to make this a non-breaking change. Could be phased out though imo, just make one of the new features a default feature instead. Fixes #43 Top commit has no ACKs. Tree-SHA512: 174b357ef228ec99149a9f25978aeca118bcb51b5138187a260552edc5f7a06b0cc236f79910cde07d44bc3a851448dc6eb5f9f8f87b839747a6fe1fad635570
4 participants
I left the default
async-httpsfeature in to make this a non-breaking change. Could be phased out though imo, just make one of the new features a default feature instead.Fixes #43