feat(api): expose bitcoin types for the API#45
Merged
vladimirfomene merged 1 commit intobitcoindevkit:masterfrom May 9, 2023
Merged
feat(api): expose bitcoin types for the API#45vladimirfomene merged 1 commit intobitcoindevkit:masterfrom
vladimirfomene merged 1 commit intobitcoindevkit:masterfrom
Conversation
In some cases, you need to use the bitcoin primitive to convert a type into another format or build a type from a hex string. This commit will reexport the primitive used in the client without forcing the caller to add the bitcoin crate as direct dependency. The motivation to have this is when you are interacting with a system that is not rust, and you do not need the rust-bitcoin. Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
vincenzopalazzo
force-pushed
the
macros/api
branch
from
44e53e5 to
c52a9a0
Compare
21 tasks
vladimirfomene
approved these changes
May 9, 2023
Member
|
@vladimirfomene once this one is merged I think it's time for a new release for this crate. Can we do it early next week? |
Contributor
|
Yes, @notmandatory you read my mind. |
19 tasks
Pull Request Test Coverage Report for Build 4591020650Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 4591020650Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
chrono-raven6i90
added a commit
to chrono-raven6i90/rust-esplora-client
that referenced
this pull request
Oct 28, 2025
… types for the API
c52a9a08bc440300a74e311dde7c5f9ce0ea9d0f feat(api): expose bitcoin types for the API (Vincenzo Palazzo)
Pull request description:
In some cases, you need to use the bitcoin primitive to convert a type into another format or build a type from a hex string.
This commit will reexport the primitive used in the client without forcing the caller to add the bitcoin crate as direct dependency.
The motivation to have this is when you are interacting with a system that is not rust, and you do not need the rust-bitcoin.
ACKs for top commit:
notmandatory:
ACK c52a9a08bc440300a74e311dde7c5f9ce0ea9d0f
vladimirfomene:
Review ACK c52a9a08bc440300a74e311dde7c5f9ce0ea9d0f
Tree-SHA512: 83a92dcfb4e8bbe6d6ca6ec2a420296cafd986122baafa252129c26d5fc176dd27ab21c40fb0b5d7d2106bb07e8964924607c2fc8f98602acae8b132730aedf9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases, you need to use the bitcoin primitive to convert a type into another format or build a type from a hex string.
This commit will reexport the primitive used in the client without forcing the caller to add the bitcoin crate as direct dependency.
The motivation to have this is when you are interacting with a system that is not rust, and you do not need the rust-bitcoin.