ci: test WASM#62
Closed
realeinherjar wants to merge 1 commit intobitcoindevkit:masterfrom
realeinherjar:einherjar/test-wasm
Closed
ci: test WASM#62realeinherjar wants to merge 1 commit intobitcoindevkit:masterfrom realeinherjar:einherjar/test-wasm
realeinherjar wants to merge 1 commit intobitcoindevkit:masterfrom
realeinherjar:einherjar/test-wasm
Conversation
Since #59 mentioned that wasm would break under certain circumstances, we have no idea when it will break. Hence, this PR adds WASM checks in the CI.
realeinherjar
commented
Oct 25, 2023
Comment on lines
-20
to
+30
| bitcoin = { version = "0.30.0", features = ["serde", "std"], default-features = false } | ||
| bitcoin = { version = "0.30.0", features = [ | ||
| "serde", | ||
| "std", | ||
| ], default-features = false } | ||
| # Temporary dependency on internals until the rust-bitcoin devs release the hex-conservative crate. | ||
| bitcoin-internals = { version = "0.1.0", features = ["alloc"] } | ||
| log = "^0.4" | ||
| ureq = { version = "2.5.0", features = ["json"], optional = true } | ||
| reqwest = { version = "0.11", optional = true, default-features = false, features = ["json"] } | ||
| reqwest = { version = "0.11", optional = true, default-features = false, features = [ | ||
| "json", | ||
| ] } |
realeinherjar
commented
Oct 25, 2023
Comment on lines
-30
to
+41
| electrsd = { version = "0.24.0", features = ["legacy", "esplora_a33e97e1", "bitcoind_22_0"] } | ||
| electrsd = { version = "0.24.0", features = [ | ||
| "legacy", | ||
| "esplora_a33e97e1", | ||
| "bitcoind_22_0", | ||
| ] } |
realeinherjar
commented
Oct 25, 2023
Comment on lines
+31
to
+32
| # WASM specific fix | ||
| getrandom = { version = "0.2", features = ["js"] } |
Author
There was a problem hiding this comment.
Only real change in Cargo.toml
Author
|
MSRV is broken. I will work on a fix in a new PR and rebase this one. |
Closed
Pull Request Test Coverage Report for Build 6645467208Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #59 mentioned that wasm would break under certain circumstances, we have no idea when it will break.
Hence, this PR adds WASM checks in the CI.
From @LLFourn in #59: