Skip to content

Conversation

@notmandatory
Copy link
Member

@notmandatory notmandatory commented Mar 21, 2024

We need to set a version for the hex dependency, crates.io does not let us publish a package with an * version.

@notmandatory notmandatory self-assigned this Mar 21, 2024
@notmandatory notmandatory added the bug Something isn't working label Mar 21, 2024
@notmandatory notmandatory added this to the Release 0.7.0 milestone Mar 21, 2024
@coveralls
Copy link

coveralls commented Mar 21, 2024

Pull Request Test Coverage Report for Build 8379354783

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.568%

Totals Coverage Status
Change from base Build 8368123947: 0.0%
Covered Lines: 959
Relevant Lines: 1134

💛 - Coveralls

Copy link
Collaborator

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b55ec14

but mind storopoli's comment as well :)

Copy link
Collaborator

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 811ff7e

Copy link

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 811ff7e

Copy link
Contributor

@vladimirfomene vladimirfomene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 811ff7e

@notmandatory notmandatory merged commit d6bff85 into master Mar 21, 2024
chrono-raven6i90 added a commit to chrono-raven6i90/rust-esplora-client that referenced this pull request Oct 28, 2025
…n, set to 0.2.0

811ff7e46c33c0491e7013144b974e509a4c9aa8 fix hex dependency version, set to 0.2 (Steve Myers)

Pull request description:

  We need to set a version for the hex dependency, crates.io does not let us publish a package with an * version.

ACKs for top commit:
  oleonardolima:
    ACK 811ff7e46c33c0491e7013144b974e509a4c9aa8
  storopoli:
    ACK 811ff7e46c33c0491e7013144b974e509a4c9aa8
  vladimirfomene:
    ACK 811ff7e46c33c0491e7013144b974e509a4c9aa8

Tree-SHA512: c778f05cd5d89016cdb4645cd6528619cf6d02631a43528c931e12ff63c048ea69eba2048eb90c9aefae754564a33f4fb969e439b870ffe149f6f7338cd7c8d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants