Skip to content
This repository was archived by the owner on Jan 22, 2026. It is now read-only.

Add a new Signer for BDK#41

Closed
wszdexdrf wants to merge 1 commit intobitcoindevkit:masterfrom
wszdexdrf:signer
Closed

Add a new Signer for BDK#41
wszdexdrf wants to merge 1 commit intobitcoindevkit:masterfrom
wszdexdrf:signer

Conversation

@wszdexdrf
Copy link
Copy Markdown
Contributor

The test for the Signer is mostly the BDK example (with small changes) available on the bdk doc homepage.

@wszdexdrf
Copy link
Copy Markdown
Contributor Author

I think this needs MSRV to be updated (bdk is now a dependency).

@wszdexdrf
Copy link
Copy Markdown
Contributor Author

The trezor emulator is failing because it has no coins. It is initialized with slip0014 (well-defined, documented way) hence people are quickly stealing the coins :D

@danielabrozzoni
Copy link
Copy Markdown
Member

The implementation seems correct, but architecturally I'd go with the other way around: instead of making bdk a dependency of rust-hwi, why not making rust-hwi a dependency on bdk? We could have a feature on bdk called "hwi" which includes the rust-hwi crate and exposes the HardwareWalletSigner

@danielabrozzoni
Copy link
Copy Markdown
Member

The trezor emulator is failing because it has no coins. It is initialized with slip0014 (well-defined, documented way) hence people are quickly stealing the coins :D

When moving this to the bdk repo you can use the bdk utils for tests, which doesn't involve moving coins, just modifying the bdk database (or start bitcoind in regtest for the functional tests)

@wszdexdrf
Copy link
Copy Markdown
Contributor Author

Moved to bitcoindevkit/bdk#682

@wszdexdrf wszdexdrf closed this Jul 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants