Add a new Signer for BDK#41
Conversation
|
I think this needs MSRV to be updated (bdk is now a dependency). |
Update MSRV
|
The trezor emulator is failing because it has no coins. It is initialized with slip0014 (well-defined, documented way) hence people are quickly stealing the coins :D |
|
The implementation seems correct, but architecturally I'd go with the other way around: instead of making bdk a dependency of rust-hwi, why not making rust-hwi a dependency on bdk? We could have a feature on bdk called "hwi" which includes the rust-hwi crate and exposes the HardwareWalletSigner |
When moving this to the bdk repo you can use the bdk utils for tests, which doesn't involve moving coins, just modifying the bdk database (or start bitcoind in regtest for the functional tests) |
|
Moved to bitcoindevkit/bdk#682 |
The test for the Signer is mostly the BDK example (with small changes) available on the bdk doc homepage.