π‘οΈ Sentinel: [security improvement] Secure snapshot directory creation#14
π‘οΈ Sentinel: [security improvement] Secure snapshot directory creation#14bitcoiner-dev wants to merge 1 commit intomasterfrom
Conversation
Co-authored-by: bitcoiner-dev <75873427+bitcoiner-dev@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: MEDIUM
π‘ Vulnerability: Snapshot directory created with permissive permissions via
std::fs::create_dir_all.π― Impact: On Unix-like systems, if a user has a permissive umask (e.g.
022), creating a directory withstd::fs::create_dir_allresults in standard permissions (e.g.755). This would make the snapshot backups readable by any other user on the system.π§ Fix: Replaced
std::fs::create_dir_allwith the repository's secure wrappercrate::paths::create_secure_dir_allto explicitly enforce0o700restricted permissions.β Verification: Ran unit tests. The change modifies the permission attributes of directories explicitly. Verify by checking created snapshot directories with
ls -ld.PR created automatically by Jules for task 6420376848358620843 started by @bitcoiner-dev