🛡️ Sentinel: [MEDIUM] Fix insecure snapshot directory permissions#15
🛡️ Sentinel: [MEDIUM] Fix insecure snapshot directory permissions#15bitcoiner-dev wants to merge 1 commit intomasterfrom
Conversation
Replaced standard `fs::create_dir_all` with the existing `create_secure_dir_all` wrapper in `src/commands/snapshot.rs`. This ensures that the sensitive wallet snapshots directories are created with strict (0o700) file permissions, instead of relying on the default umask. Co-authored-by: bitcoiner-dev <75873427+bitcoiner-dev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🚨 Severity: MEDIUM
💡 Vulnerability: The snapshot directory containing sensitive wallet state and backups was created using the standard
std::fs::create_dir_allfunction without explicitly setting file permissions. This relies on the default process umask.🎯 Impact: Depending on the host machine's configuration, the snapshot directory might be readable or writable by other non-privileged users on the system, potentially exposing wallet keys and metadata.
🔧 Fix: Used the existing utility
crate::paths::create_secure_dir_allinstead. This utility wrapsDirBuilderExtto explicitly setmode(0o700)on Unix systems, locking down directory access to only the owning user.✅ Verification: Ran
cargo testandcargo checkto ensure correctness. Verified thatcreate_secure_dir_allis properly mapped and invoked.PR created automatically by Jules for task 13216546673017836747 started by @bitcoiner-dev