Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix path traversal in profile and snapshot paths#21

Open
bitcoiner-dev wants to merge 1 commit intomasterfrom
fix-path-traversal-vuln-1542657143684160733
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix path traversal in profile and snapshot paths#21
bitcoiner-dev wants to merge 1 commit intomasterfrom
fix-path-traversal-vuln-1542657143684160733

Conversation

@bitcoiner-dev
Copy link
Copy Markdown
Owner

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: The application constructed file paths for profiles and snapshots without sanitizing the profile_name or snapshot_name variables, allowing path traversal (e.g., via ../../).
🎯 Impact: An attacker or malicious configuration could cause the application to read, write, or overwrite arbitrary files on the filesystem.
πŸ”§ Fix: Implemented validate_file_name in src/utils.rs to enforce an allowlist of characters (alphanumeric, underscores, and dashes) and applied this validation to config.profile and snapshot name arguments. Removed an insecure directory creation call in snapshot.rs since snapshot_dir() handles it securely.
βœ… Verification: cargo test passes. Running with an invalid profile name (e.g., --profile ../../root) will immediately error out with Invalid input.


PR created automatically by Jules for task 1542657143684160733 started by @bitcoiner-dev

Co-authored-by: bitcoiner-dev <75873427+bitcoiner-dev@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant