π‘οΈ Sentinel: [CRITICAL] Fix path traversal in profile and snapshot paths#21
π‘οΈ Sentinel: [CRITICAL] Fix path traversal in profile and snapshot paths#21bitcoiner-dev wants to merge 1 commit intomasterfrom
Conversation
Co-authored-by: bitcoiner-dev <75873427+bitcoiner-dev@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: The application constructed file paths for profiles and snapshots without sanitizing the
profile_nameorsnapshot_namevariables, allowing path traversal (e.g., via../../).π― Impact: An attacker or malicious configuration could cause the application to read, write, or overwrite arbitrary files on the filesystem.
π§ Fix: Implemented
validate_file_nameinsrc/utils.rsto enforce an allowlist of characters (alphanumeric, underscores, and dashes) and applied this validation toconfig.profileand snapshotnamearguments. Removed an insecure directory creation call insnapshot.rssincesnapshot_dir()handles it securely.β Verification:
cargo testpasses. Running with an invalid profile name (e.g.,--profile ../../root) will immediately error out withInvalid input.PR created automatically by Jules for task 1542657143684160733 started by @bitcoiner-dev