🛡️ Sentinel: [CRITICAL] Fix path traversal in snapshot management#22
🛡️ Sentinel: [CRITICAL] Fix path traversal in snapshot management#22bitcoiner-dev wants to merge 1 commit intomasterfrom
Conversation
- Added `validate_file_name` in `src/utils.rs` with strict alphanumeric/dash/underscore allowlist. - Validated user input for both snapshot Save and Restore actions to prevent path traversal vectors. Co-authored-by: bitcoiner-dev <75873427+bitcoiner-dev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🚨 Severity: CRITICAL
💡 Vulnerability: The snapshot management command blindly joined user-provided snapshot names directly to the snapshot directory (
snap_dir.join(format!("{name}.json"))). This allowed a path traversal vulnerability where inputs like../could be used to manipulate files outside of the intended directory.🎯 Impact: If exploited, this could lead to arbitrary file reads (via Restore) or arbitrary file overwriting (via Save), potentially exposing sensitive user data or corrupting the configuration.
🔧 Fix: Implemented an explicit allowlist validation function (
crate::utils::validate_file_name) that strictly restricts filenames to alphanumeric characters, dashes, and underscores. Applied this validation proactively in the snapshotSaveandRestoreoperations.✅ Verification: Unit tests have been added to ensure the validation rejects malicious inputs (like
../and/etc). The fullzinc-wallet-clitest suite was run and passed successfully.PR created automatically by Jules for task 1676231061828451625 started by @bitcoiner-dev