fix: treat zero value outputs as pre-defined#71
Merged
junderw merged 2 commits intobitcoinjs:masterfrom Jun 14, 2022
Merged
Conversation
junderw
force-pushed
the
master
branch
3 times, most recently
from
69001ce to
2f99d56
Compare
Member
|
Please rebase (added Github Actions and package-lock etc.) |
Contributor
Author
should be up to date now |
junderw
approved these changes
Jun 14, 2022
Member
|
published as 3.1.13 |
Contributor
Author
Thanks for getting this in and published so quickly! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, outputs with a value of
0were being treated as a split output. This change only treats outputs with a value ofundefinedas split outputs. This allows you to pass through a zero value script (OP_RETURN) output into the coinselectsplitfunction without it increasing thesplitOutputsCount, resulting in a correct and expected result.