feat: calculate segwit, taproot and script hash input/output bytes#82
feat: calculate segwit, taproot and script hash input/output bytes#82ChrisCho-H wants to merge 5 commits intobitcoinjs:masterfrom
Conversation
|
+1 for this. I may have to go as far as using @ChrisCho-H 's fork / branch directly in my package.json since we use Segwit and it'd save us a lot on fees if this can't get in by the end of the month... @Overtorment could you review? ❤️ I looked it over and the calculation looks ok, but I'm not intimately familiar with TX size calculation. |
|
thanks a lot. it works for p2pkh, p2sh and p2wpkh(segwit). |
|
@LeeKorbisCa I published my forked version to npm |
|
@Overtorment could you please review when you've got a moment? 😃 (Pinging you since it seems junderw delegates to you :)) |
|
@ChrisCho-H I'm now using your fork in the meantime. Thank you again for publishing this |
|
|
|
@junderw maybe you can help with the review? The feature with seg-wit & TapRoot coin selection seems to be very necessary for JS bitcoiners |
|
@landabaso would u mind to review it? |
add logic to calculate segwit, taproot and script hash input and output to support satoshi per vbyte.