-
Notifications
You must be signed in to change notification settings - Fork 13
Make it a real library #102
Conversation
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
|
So based on the good experience with vcard4android, I think we can continue with ical4android 😄 |
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
|
I think it's now good |
|
Looks smart enough to me. I have got no idea how to test it though? Just following the readme instructions does not work as jitpack can't find it as a lib yet, right? |
In fact, it should. It's working on my PC, can you try https://github.com/bitfireAT/davx5/pull/302 by yourself? |
Ah, right! I missed the branched over at davx5 :) It does not work for me however. I get a lot of errors when trying to build the app. I tried clearing the cache and restarting AS but that did not help. Details |
|
Okay, I'll take a look asap |
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
rfc2822
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, happy to merge :)
Closes #101