This repository was archived by the owner on Jun 9, 2025. It is now read-only.
Ignore RDATEs when there's an also an infinite RRULE to avoid calendar provider exception #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r provider exception
Member
Author
|
@ArnyminerZ Could you please add a test
And then set the status to Ready for review (hopefully you can do that as I have created the PR) and request a review from @sunkup? |
rfc2822
added
bug
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
rfc2822
commented
Sep 12, 2023
Member
Author
rfc2822
left a comment
rfc2822
left a comment
There was a problem hiding this comment.
Thanks @ArnyminerZ @sunkup
Unfortunately this "solution" still means data loss (the RDATE instances are not shown), but at least it doesn't break whole sync for now
rfc2822
deleted the
113-calendarstorageexception-when-infinite-rrule-+-rdate-present
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #113