Skip to content
This repository was archived by the owner on Jun 9, 2025. It is now read-only.

Conversation

@ArnyminerZ
Copy link
Member

I've removed the TZURL and X-LIC-LOCATION properties, and added a test that makes sure there are no references to Berlin when using Copenhagen.

Also changed the log level to fine, and modified the message to be less dramatic.

Timezone Definition
BEGIN:VTIMEZONE
LAST-MODIFIED:20240422T053450Z
X-PROLEPTIC-TZNAME:LMT
TZID:Europe/Copenhagen
BEGIN:STANDARD
TZNAME:CET
TZOFFSETFROM:+005328
TZOFFSETTO:+0100
DTSTART:18930401T011444
END:STANDARD
BEGIN:DAYLIGHT
TZNAME:CEST
TZOFFSETFROM:+0100
TZOFFSETTO:+0200
DTSTART:19160501T000000
RDATE:19400401T020000
RDATE:19430329T020000
RDATE:19460414T020000
RDATE:19470406T030000
RDATE:19480418T020000
RDATE:19490410T020000
RDATE:19800406T020000
END:DAYLIGHT
BEGIN:STANDARD
TZNAME:CET
TZOFFSETFROM:+0200
TZOFFSETTO:+0100
DTSTART:19161001T020000
RDATE:19421102T030000
RDATE:19431004T030000
RDATE:19441002T030000
RDATE:19451118T030000
RDATE:19461007T030000
END:STANDARD
BEGIN:DAYLIGHT
TZNAME:CEST
TZOFFSETFROM:+0100
TZOFFSETTO:+0200
DTSTART:19170416T030000
RRULE:FREQ=YEARLY;UNTIL=19180415T010000Z;BYMONTH=4;BYDAY=3MO
END:DAYLIGHT
BEGIN:STANDARD
TZNAME:CET
TZOFFSETFROM:+0200
TZOFFSETTO:+0100
DTSTART:19170917T040000
RRULE:FREQ=YEARLY;UNTIL=19180916T010000Z;BYMONTH=9;BYDAY=3MO
END:STANDARD
BEGIN:DAYLIGHT
TZNAME:CEST
TZOFFSETFROM:+0100
TZOFFSETTO:+0200
DTSTART:19440403T020000
RRULE:FREQ=YEARLY;UNTIL=19450402T010000Z;BYMONTH=4;BYDAY=1MO
END:DAYLIGHT
BEGIN:DAYLIGHT
TZNAME:CEMT
TZOFFSETFROM:+0200
TZOFFSETTO:+0300
DTSTART:19450524T020000
RDATE:19470511T030000
END:DAYLIGHT
BEGIN:DAYLIGHT
TZNAME:CEST
TZOFFSETFROM:+0300
TZOFFSETTO:+0200
DTSTART:19450924T030000
RDATE:19470629T030000
END:DAYLIGHT
BEGIN:STANDARD
TZNAME:CET
TZOFFSETFROM:+0100
TZOFFSETTO:+0100
DTSTART:19460101T000000
RDATE:19800101T000000
END:STANDARD
BEGIN:STANDARD
TZNAME:CET
TZOFFSETFROM:+0200
TZOFFSETTO:+0100
DTSTART:19471005T030000
RRULE:FREQ=YEARLY;UNTIL=19491002T010000Z;BYMONTH=10;BYDAY=1SU
END:STANDARD
BEGIN:STANDARD
TZNAME:CET
TZOFFSETFROM:+0200
TZOFFSETTO:+0100
DTSTART:19800928T030000
RRULE:FREQ=YEARLY;UNTIL=19950924T010000Z;BYMONTH=9;BYDAY=-1SU
END:STANDARD
BEGIN:DAYLIGHT
TZNAME:CEST
TZOFFSETFROM:+0100
TZOFFSETTO:+0200
DTSTART:19810329T020000
RRULE:FREQ=YEARLY;BYMONTH=3;BYDAY=-1SU
END:DAYLIGHT
BEGIN:STANDARD
TZNAME:CET
TZOFFSETFROM:+0200
TZOFFSETTO:+0100
DTSTART:19961027T030000
RRULE:FREQ=YEARLY;BYMONTH=10;BYDAY=-1SU
END:STANDARD
END:VTIMEZONE

Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ ArnyminerZ added the refactoring Quality improvement of existing functions label Aug 14, 2024
@ArnyminerZ ArnyminerZ self-assigned this Aug 14, 2024
@ArnyminerZ ArnyminerZ requested a review from sunkup August 14, 2024 08:30
Copy link
Member

@sunkup sunkup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but when I run the test I can't see the log message in the logcat. Maybe, if I could somehow change some setting to show log level FINE, it would show up, but are you sure we should use log level FINE here? Ricki wrote to use "debug info level" ...

@ArnyminerZ
Copy link
Member Author

Well, I used fine because debug is not actually a debug level. See Level.

The levels are:

  • SEVERE (highest value)
  • WARNING
  • INFO
  • CONFIG
  • FINE
  • FINER
  • FINEST (lowest value)

So I guessed the most similar one would be fine. If you find that another level suits more just tell me and I will change it.

The thing is that here we don't use Android's Log but Java's Logger, so I don't know how they relate.

@sunkup
Copy link
Member

sunkup commented Aug 16, 2024

Ricki wrote to use "debug info level" ...

The debug level Ricki meant was most likely INFO, but I can see the confusion with the word "info" :D

@ArnyminerZ
Copy link
Member Author

The debug level Ricki meant was most likely INFO, but I can see the confusion with the word "info" :D

Aaaaah I get it, I'll change it now 😉

Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
…-logs-inappropriate-warning-when-constructing-europecopenhagen-from-europeberlin
@ArnyminerZ ArnyminerZ requested a review from sunkup August 17, 2024 09:51
@sunkup sunkup removed their request for review August 19, 2024 07:03
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ ArnyminerZ requested a review from rfc2822 August 19, 2024 17:41
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
Copy link
Member

@rfc2822 rfc2822 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@rfc2822 rfc2822 merged commit cb94343 into main Aug 20, 2024
@rfc2822 rfc2822 deleted the 168-androidcompattimezoneregistry-logs-inappropriate-warning-when-constructing-europecopenhagen-from-europeberlin branch August 20, 2024 13:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

refactoring Quality improvement of existing functions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AndroidCompatTimeZoneRegistry logs inappropriate warning when constructing Europe/Copenhagen from Europe/Berlin

3 participants