-
Notifications
You must be signed in to change notification settings - Fork 13
AndroidCompatTimeZoneRegistry logs inappropriate warning when constructing Europe/Copenhagen from Europe/Berlin #170
Conversation
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but when I run the test I can't see the log message in the logcat. Maybe, if I could somehow change some setting to show log level FINE, it would show up, but are you sure we should use log level FINE here? Ricki wrote to use "debug info level" ...
|
Well, I used fine because debug is not actually a debug level. See The levels are:
So I guessed the most similar one would be fine. If you find that another level suits more just tell me and I will change it. The thing is that here we don't use Android's |
The debug level Ricki meant was most likely |
Aaaaah I get it, I'll change it now 😉 |
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
…-logs-inappropriate-warning-when-constructing-europecopenhagen-from-europeberlin
lib/src/main/kotlin/at/bitfire/ical4android/AndroidCompatTimeZoneRegistry.kt
Outdated
Show resolved
Hide resolved
lib/src/main/kotlin/at/bitfire/ical4android/AndroidCompatTimeZoneRegistry.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
lib/src/main/kotlin/at/bitfire/ical4android/AndroidCompatTimeZoneRegistry.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
rfc2822
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice :)
I've removed the
TZURLandX-LIC-LOCATIONproperties, and added a test that makes sure there are no references to Berlin when using Copenhagen.Also changed the log level to fine, and modified the message to be less dramatic.
Timezone Definition