Skip to content
This repository was archived by the owner on Jun 9, 2025. It is now read-only.

Conversation

@ArnyminerZ
Copy link
Member

Closes #77

Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
@ArnyminerZ ArnyminerZ added the bug Something isn't working label Feb 7, 2023
@ArnyminerZ ArnyminerZ self-assigned this Feb 7, 2023
@ArnyminerZ ArnyminerZ linked an issue Feb 7, 2023 that may be closed by this pull request
@ArnyminerZ ArnyminerZ marked this pull request as ready for review February 7, 2023 09:53
@ArnyminerZ ArnyminerZ requested a review from rfc2822 February 7, 2023 09:53
@rfc2822 rfc2822 requested a review from sunkup February 7, 2023 13:20
Copy link
Member

@sunkup sunkup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good :)

Copy link
Member

@rfc2822 rfc2822 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@rfc2822 rfc2822 merged commit 1c6bcb3 into main Feb 8, 2023
@rfc2822 rfc2822 deleted the 77-handling-period-durations-of-days-with-t-prefix branch February 8, 2023 10:01
@devvv4ever
Copy link
Member

@ArnyminerZ Didn't this fix make it to 2.1.1? The original URL is still unable to be parsed with the "Text cannot be parsed to a Duration" exception...

@ArnyminerZ
Copy link
Member Author

@rfc2822 would tell better, but I think so

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handling period durations of days with T prefix

4 participants