This repository was archived by the owner on Jun 9, 2025. It is now read-only.
Ignore invalid properties #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
3 tasks
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
…perties # Conflicts: # build.gradle
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
rfc2822
suggested changes
Mar 23, 2023
Member
rfc2822
left a comment
rfc2822
left a comment
There was a problem hiding this comment.
Thanks, nice to finally have this. I have added some minor comments.
Can you please try whether these cases (see original issue bitfireAT/davx5#165) are covered by the fix too? Probably we don't need separate tests for them because these tests would belong to ical4j and are not that important for us (I'd just like to know whether these cases are covered too):
GEO:
GEO:48.786829
GEO:48.786829;27.801019
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Member
Author
I've manually tested it by replacing the |
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
rfc2822
force-pushed
the
81-ignore-invalid-properties
branch
from
e7ec556 to
9013a92
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Arnau Mora arnyminer.z@gmail.com
Closes #81