Skip to content
This repository was archived by the owner on Jun 9, 2025. It is now read-only.

Conversation

@ArnyminerZ
Copy link
Member

@ArnyminerZ ArnyminerZ commented Mar 9, 2023

Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
@ArnyminerZ ArnyminerZ marked this pull request as ready for review March 9, 2023 12:49
@leonggs
Copy link

leonggs commented Mar 10, 2023

Recently, I've imported a third-party ics file to my Nextcloud calendar containing SEQUENCE:2302221158. It misuses the sequence field as booking date or something like that. All implementations such as ical4j that conform to the iCalendar RFC standard might fail parsing this encoding as 32 bit signed integers since 01.01.2022. Dear third-party, you have constructed a year2k, seriously? :D

  • Nextcloud Calendar doesn't discard this standard-violating event, which I expect my calendar apps to do!
  • Davx 4.3-ose does and displays an inconvenient error in the notification bar containing net.fortuna.ical4j.data.ParserException in its stack trace. For average users it's probably not possible to identify the problematic remote resource/event that causes that error.

Do this fix in the current issue fix my problem described above as well and will they be in the next release of Davx without further actions?

@rfc2822
Copy link
Member

rfc2822 commented Mar 13, 2023

Shall we merge it although it does not fix the original problem?

@ArnyminerZ
Copy link
Member Author

Mmmh... Maybe... It's always good to have dependencies updated, there might be other bugfixes

@rfc2822
Copy link
Member

rfc2822 commented Mar 15, 2023

Agree…

There's a failing test though.

@ArnyminerZ
Copy link
Member Author

The failing test is annotated with "should not fail in future", so it must have been fixed 😄

Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
@rfc2822
Copy link
Member

rfc2822 commented Mar 15, 2023

Ah, nice, seems that it fixes a Persian Locale bug. Please keep the test to be sure in the future and just remove the failure expectation :)

Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Copy link
Member

@rfc2822 rfc2822 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@rfc2822 rfc2822 merged commit cf5c663 into main Mar 15, 2023
@rfc2822 rfc2822 deleted the update_ical4j branch March 15, 2023 10:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants