Skip to content
This repository was archived by the owner on Jun 9, 2025. It is now read-only.

Conversation

@ArnyminerZ
Copy link
Member

No description provided.

Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
@ArnyminerZ ArnyminerZ self-assigned this Apr 11, 2023
@ArnyminerZ ArnyminerZ linked an issue Apr 11, 2023 that may be closed by this pull request
3 tasks
@ArnyminerZ ArnyminerZ marked this pull request as ready for review April 11, 2023 08:09
@ArnyminerZ ArnyminerZ requested a review from sunkup April 11, 2023 08:09
Copy link
Member

@sunkup sunkup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Solves the problem and looks good.

I like that, by using regex for comparison, we can easily see the timezone is being ignored. What I do not like is using assertTrue() instead of assertEquals(), as the latter gives more information on why the test failed in the console. I imagine

assertEquals("20150101T000000Z,20150702T000000Z", androidString.substringAfter(";"))

would be better in that regard. It does make it less clear, that we are ignoring the timezone, however. So you can change that or leave it, as I think both would be fine.

testHasUntilBeforeDtStart_DtStartDate_RRuleUntil_TimeBeforeDtStart_noTimezone does not fail on me anymore either.

Maybe change androidString into androidTimeString to make it a bit more clear - if you want :)

Approved 👍

@rfc2822
Copy link
Member

rfc2822 commented Apr 12, 2023

Thanks @ArnyminerZ @sunkup!

@ArnyminerZ Please change to assertEquals, then I'll merge!

Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
@rfc2822 rfc2822 merged commit 92e3abf into main Apr 12, 2023
@rfc2822 rfc2822 deleted the 49-tests-should-work-under-every-system-time-zone branch April 12, 2023 22:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests should work under every system time zone

3 participants