This repository was archived by the owner on Jun 9, 2025. It is now read-only.
Ignore custom VTIMEZONEs that can't be properly handled by ical4j #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfc2822
force-pushed
the
davx541-events-with-the-europedublin-timezone-are-displayed-on-2300-on-previous-day-2
branch
from
1aa0b3c to
aa285d6
Compare
rfc2822
commented
May 9, 2023
src/main/java/at/bitfire/ical4android/validation/ICalPreprocessor.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
… be handled properly by ical4j
rfc2822
force-pushed
the
davx541-events-with-the-europedublin-timezone-are-displayed-on-2300-on-previous-day-2
branch
from
3f9bf48 to
a5ca33e
Compare
…e-are-displayed-on-2300-on-previous-day-2
rfc2822
deleted the
davx541-events-with-the-europedublin-timezone-are-displayed-on-2300-on-previous-day-2
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully closes #94
The key is that it doesn't accept the VTIMEZONE updates that break ical4j. If such an update arrives from the iCalendar parser, it's ignored so that the default VTIMEZONE for the respective TZID remains active and calculations use the default time zone.