Skip to content
This repository was archived by the owner on Jun 9, 2025. It is now read-only.

Conversation

@patrickunterwegs
Copy link
Member

No description provided.

@patrickunterwegs
Copy link
Member Author

Hi @rfc2822 , the new tests obviously fail now because the version of jtx Board that contains those new fields doesn't exist yet as an apk. How would you like to proceed here? Would you like to accept that the test fails for now or should I deactivate them?
A third option could maybe be to check the jtx Board version and skip the test if the version is old... (I'm not sure if this would work though for the android test)

@rfc2822
Copy link
Member

rfc2822 commented May 11, 2023

A third option could maybe be to check the jtx Board version and skip the test if the version is old... (I'm not sure if this would work though for the android test)

Sounds to be the most reasonable for me. You could JUnit Assume to skip the tests depending on the jtx Board version. But then we shouldn't forget to update the APK link as soon as the latest one is available ;)

@patrickunterwegs
Copy link
Member Author

Alright, thanks, it's ready now 👍

@rfc2822 rfc2822 merged commit eeca011 into main May 11, 2023
@rfc2822 rfc2822 deleted the add-geofence-radius-x-property branch May 11, 2023 14:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants