Claude/address report issues 011 c uhf98bf eq kig avwpfy xk#395
Merged
Jamie-BitFlight merged 2 commits intomainfrom Nov 1, 2025
Merged
Conversation
Fixes #280 The CLI executable was missing the #!/usr/bin/env node shebang, causing the shell to interpret the JavaScript code directly. This resulted in the error: "syntax error near unexpected token 'async'" The fix adds the shebang to the ESM_REQUIRE_SHIM in esbuild.mjs, ensuring the CLI runs correctly on Node 20+. Validated by: - Replicating the error with the broken version - Applying the fix and rebuilding - Confirming --help and --version commands work - Verifying no async syntax errors
|
Caution Review failedThe pull request is closed. WalkthroughA shebang line (#!/usr/bin/env node) has been prepended to the ESM_REQUIRE_SHIM constant in scripts/esbuild.mjs, enabling the generated bundled output to be directly executable as a Node.js script. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes ✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (7)
📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Coverage Report
File CoverageNo changed files found. |
Jamie-BitFlight
deleted the
claude/address-report-issues-011CUhf98bfEqKigAvwpfyXK
branch
Jamie-BitFlight
pushed a commit
that referenced
this pull request
Nov 1, 2025
Addresses 26 security vulnerabilities reported by npm audit: - Fixed all 6 high severity vulnerabilities - Fixed all 13 moderate severity vulnerabilities - 5 low severity issues remain (in dev-only commit tooling) Major updates: - esbuild: 0.19.5 → 0.25.11 (fixes dev server vulnerability) - vitest: 0.34.6 → 4.0.6 (major version update) - @vitest/coverage-v8: 0.34.6 → 4.0.6 - @commitlint/prompt: 18.2.0 → 20.1.0 - commitizen: 4.3.0 → 4.3.1 Security fixes include: - Babel RegExp complexity (moderate) - Octokit ReDoS vulnerabilities (moderate) - brace-expansion ReDoS (moderate) - braces resource consumption (high) - cross-spawn ReDoS (high) - rollup DOM clobbering (high) - nanoid predictability (moderate) - undici fetch issues (moderate) All tests passed: - Build completes successfully - CLI runs without errors - Shebang fix from PR #395 remains intact
Jamie-BitFlight
pushed a commit
that referenced
this pull request
Nov 1, 2025
This commit addresses multiple issues: 1. Security vulnerabilities (26 → 5 remaining, all low severity) - Fixed all 6 high severity vulnerabilities - Fixed all 13 moderate severity vulnerabilities - Remaining 5 are low severity in dev-only commit tooling 2. Fixed critical bug preventing CLI from working (issue #335) - Bug: repositoryFinder only checked environment variables - Impact: --owner and --repo CLI arguments were ignored - Fix: Now checks config (which includes CLI args) before env vars - Verified: README generation now works correctly 3. Dependency updates: - esbuild: 0.19.5 → 0.25.11 (fixes dev server vulnerability) - vitest: 0.34.6 → 4.0.6 - @vitest/coverage-v8: 0.34.6 → 4.0.6 - @commitlint/prompt: 18.2.0 → 20.1.0 - commitizen: 4.3.0 → 4.3.1 4. Security fixes include: - Babel RegExp complexity (moderate) - Octokit ReDoS vulnerabilities (moderate) - brace-expansion ReDoS (moderate) - braces resource consumption (high) - cross-spawn ReDoS (high) - rollup DOM clobbering (high) - nanoid predictability (moderate) - undici fetch issues (moderate) Tested and verified: - Build completes successfully - CLI runs with --owner/--repo arguments - README generation works end-to-end - Shebang fix from PR #395 remains intact
Jamie-BitFlight
pushed a commit
that referenced
this pull request
Nov 1, 2025
This commit addresses multiple issues: 1. Security vulnerabilities (26 → 5 remaining, all low severity) - Fixed all 6 high severity vulnerabilities - Fixed all 13 moderate severity vulnerabilities - Remaining 5 are low severity in dev-only commit tooling 2. Fixed critical bug preventing CLI from working (issue #335) - Bug: repositoryFinder only checked environment variables - Impact: --owner and --repo CLI arguments were ignored - Fix: Now checks config (which includes CLI args) before env vars - Verified: README generation now works correctly 3. Dependency updates: - esbuild: 0.19.5 → 0.25.11 (fixes dev server vulnerability) - vitest: 0.34.6 → 4.0.6 - @vitest/coverage-v8: 0.34.6 → 4.0.6 - @commitlint/prompt: 18.2.0 → 20.1.0 - commitizen: 4.3.0 → 4.3.1 4. Security fixes include: - Babel RegExp complexity (moderate) - Octokit ReDoS vulnerabilities (moderate) - brace-expansion ReDoS (moderate) - braces resource consumption (high) - cross-spawn ReDoS (high) - rollup DOM clobbering (high) - nanoid predictability (moderate) - undici fetch issues (moderate) Tested and verified: - Build completes successfully - CLI runs with --owner/--repo arguments - README generation works end-to-end - Shebang fix from PR #395 remains intact
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit