fix: remove legacy-peer-deps by eliminating unmaintained ESLint plugins#442
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
…ackages Co-authored-by: Jamie-BitFlight <25075504+Jamie-BitFlight@users.noreply.github.com>
| 'n/no-missing-import': 'off', | ||
|
|
||
| // sonarjs recommended - commented out due to ES Lint 9 compatibility issues | ||
| // sonarjs recommended - Re-enabled with v3.0.5 but disabled for now due to many new findings that should be addressed separately |
There was a problem hiding this comment.
When would the issues ever get addressed? Are you already organizing to fix them in issues and milestones? Or are you setting this to disabled and ignored forever? Please use your infinite mind to think through and address the linting issues found. This is meant to be healthy, professional, modern. You have the capacity to do this so amazingly and yet you ignored it. Take it on. It's January 2026, you can make this follow the best of the best code standards. Please review this code, and apply SOLID development principles and hit those high standards. Lint your own work before committing and see what you missed. Address anything found and repeat. You got this!
| plugins: { | ||
| actions: actionsPlugin, | ||
| }, | ||
| processor: 'actions/actions', |
There was a problem hiding this comment.
Is there a modern replacement for this old module? If so please replace it with the new one.
Coverage Report
File CoverageNo changed files found. |
1 similar comment
Coverage Report
File CoverageNo changed files found. |
|
@copilot try again |
There was a problem hiding this comment.
Pull request overview
This PR removes the legacy-peer-deps=true flag from .npmrc by eliminating unmaintained ESLint plugins that were incompatible with ESLint 9. The change resolves peer dependency conflicts that were previously being masked.
Changes:
- Removed unmaintained
eslint-plugin-actions@2.0.0(last maintained May 2022, ESLint 8 only) - Upgraded
eslint-plugin-sonarjsfrom 0.25.1 to 3.0.5 (adds ESLint 9 support) - Removed
legacy-peer-deps=trueflag from.npmrcto enforce proper dependency resolution
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.npmrc |
Removes legacy-peer-deps=true flag now that peer dependency conflicts are resolved |
package.json |
Removes eslint-plugin-actions@2.0.0 and upgrades eslint-plugin-sonarjs to 3.0.5 |
package-lock.json |
Updates dependency tree reflecting plugin removal and upgrade, including transitive dependency updates |
eslint.config.mjs |
Removes actions plugin import and configuration block; updates comments about sonarjs plugin status |
c73775a
into
dependabot/npm_and_yarn/eslint-plugin-unicorn-62.0.0
|
🎉 This PR is included in version 1.8.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
The
legacy-peer-deps=trueflag in.npmrcwas masking peer dependency conflicts from unmaintained packages incompatible with ESLint 9.Changes
Removed
eslint-plugin-actions@2.0.0- Unmaintained since May 2022, only supports ESLint 8. Lints inline JavaScript in workflow files, which this project doesn't use.Upgraded
eslint-plugin-sonarjs0.25.1 → 3.0.5 - Adds ESLint 9 support. Plugin remains disabled in config (existing state) but is now upgrade-ready.Removed
legacy-peer-deps=truefrom.npmrc- No longer needed.npm installnow runs cleanly without peer dependency warnings.Context
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.