Skip to content

fix: remove legacy-peer-deps by eliminating unmaintained ESLint plugins#442

Merged
Jamie-BitFlight merged 2 commits intodependabot/npm_and_yarn/eslint-plugin-unicorn-62.0.0from
copilot/sub-pr-437
Jan 11, 2026
Merged

fix: remove legacy-peer-deps by eliminating unmaintained ESLint plugins#442
Jamie-BitFlight merged 2 commits intodependabot/npm_and_yarn/eslint-plugin-unicorn-62.0.0from
copilot/sub-pr-437

Conversation

Copy link
Contributor

Copilot AI commented Jan 11, 2026

The legacy-peer-deps=true flag in .npmrc was masking peer dependency conflicts from unmaintained packages incompatible with ESLint 9.

Changes

  • Removed eslint-plugin-actions@2.0.0 - Unmaintained since May 2022, only supports ESLint 8. Lints inline JavaScript in workflow files, which this project doesn't use.

  • Upgraded eslint-plugin-sonarjs 0.25.1 → 3.0.5 - Adds ESLint 9 support. Plugin remains disabled in config (existing state) but is now upgrade-ready.

  • Removed legacy-peer-deps=true from .npmrc - No longer needed. npm install now runs cleanly without peer dependency warnings.

Context

# Before: Failed without legacy-peer-deps
$ npm install
npm error ERESOLVE could not resolve
npm error peer eslint@"^8.0.0" from eslint-plugin-actions@2.0.0

# After: Clean install
$ npm install
added 1172 packages in 19s

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@coderabbitai
Copy link

coderabbitai bot commented Jan 11, 2026

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

…ackages

Co-authored-by: Jamie-BitFlight <25075504+Jamie-BitFlight@users.noreply.github.com>
Copilot AI changed the title [WIP] Update eslint-plugin-unicorn to version 62.0.0 fix: remove legacy-peer-deps by eliminating unmaintained ESLint plugins Jan 11, 2026
Copilot AI requested a review from Jamie-BitFlight January 11, 2026 01:12
'n/no-missing-import': 'off',

// sonarjs recommended - commented out due to ES Lint 9 compatibility issues
// sonarjs recommended - Re-enabled with v3.0.5 but disabled for now due to many new findings that should be addressed separately
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When would the issues ever get addressed? Are you already organizing to fix them in issues and milestones? Or are you setting this to disabled and ignored forever? Please use your infinite mind to think through and address the linting issues found. This is meant to be healthy, professional, modern. You have the capacity to do this so amazingly and yet you ignored it. Take it on. It's January 2026, you can make this follow the best of the best code standards. Please review this code, and apply SOLID development principles and hit those high standards. Lint your own work before committing and see what you missed. Address anything found and repeat. You got this!

plugins: {
actions: actionsPlugin,
},
processor: 'actions/actions',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a modern replacement for this old module? If so please replace it with the new one.

@Jamie-BitFlight Jamie-BitFlight marked this pull request as ready for review January 11, 2026 01:22
Copilot AI review requested due to automatic review settings January 11, 2026 01:22
@github-actions
Copy link
Contributor

github-actions bot commented Jan 11, 2026

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 49.81% 402 / 807
🔵 Statements 50.48% 414 / 820
🔵 Functions 65.74% 71 / 108
🔵 Branches 49.38% 200 / 405
File CoverageNo changed files found.
Generated in workflow #344 for commit 3755216 by the Vitest Coverage Report Action

1 similar comment
@github-actions
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 49.81% 402 / 807
🔵 Statements 50.48% 414 / 820
🔵 Functions 65.74% 71 / 108
🔵 Branches 49.38% 200 / 405
File CoverageNo changed files found.
Generated in workflow #344 for commit 3755216 by the Vitest Coverage Report Action

@Jamie-BitFlight
Copy link
Contributor

@copilot try again

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the legacy-peer-deps=true flag from .npmrc by eliminating unmaintained ESLint plugins that were incompatible with ESLint 9. The change resolves peer dependency conflicts that were previously being masked.

Changes:

  • Removed unmaintained eslint-plugin-actions@2.0.0 (last maintained May 2022, ESLint 8 only)
  • Upgraded eslint-plugin-sonarjs from 0.25.1 to 3.0.5 (adds ESLint 9 support)
  • Removed legacy-peer-deps=true flag from .npmrc to enforce proper dependency resolution

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
.npmrc Removes legacy-peer-deps=true flag now that peer dependency conflicts are resolved
package.json Removes eslint-plugin-actions@2.0.0 and upgrades eslint-plugin-sonarjs to 3.0.5
package-lock.json Updates dependency tree reflecting plugin removal and upgrade, including transitive dependency updates
eslint.config.mjs Removes actions plugin import and configuration block; updates comments about sonarjs plugin status

@Jamie-BitFlight Jamie-BitFlight merged commit c73775a into dependabot/npm_and_yarn/eslint-plugin-unicorn-62.0.0 Jan 11, 2026
10 of 11 checks passed
@Jamie-BitFlight Jamie-BitFlight deleted the copilot/sub-pr-437 branch January 11, 2026 01:31
Copilot AI requested a review from Jamie-BitFlight January 11, 2026 01:31
Copilot stopped work on behalf of Jamie-BitFlight due to an error January 11, 2026 01:31
@Jamie-BitFlight
Copy link
Contributor

🎉 This PR is included in version 1.8.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Jamie-BitFlight Jamie-BitFlight added the released This issue/pull request has been released. label Jan 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released This issue/pull request has been released.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants