Segwit/segnet development support

[braydonf]

Here is a rough breakdown of tasks needed to bring segwit support to bitcore libraries:

Bitcore Library:

• Address
  • New address type for pay-to-witness-public-key-hash and pay-to-witness-script-hash (BIP0142) DEFERRED
  • Expand associated address methods to use the new formats to build the corresponding scripts DEFERRED
• Transaction
  • New transaction serialization format, expand toBuffer/fromBuffer for bitcore-lib to include additional support for segwit serialization format. This is mostly identical to existing implementation with an additional flag that indicates segwit tx, and a new field for scriptWitness on the input (BIP0144) IMPLEMENTED
  • New transaction hash that does not include witness, and one that does include the witness (BIP0144) IMPLEMENTED
  • Support signing inputs with the new witness programs for pay-to-witness-public-key-hash and pay-to-witness-script-hash (BIP0141)
  • Support signing inputs and making transactions with traditional P2SH with segwit (BIP0141). IMPLEMENTED
• Network
  • Add segnet network alongside and similar to regtest network options IMPLEMENTED
• Script
  • Add script evaluation for witness data (BIP0141) IMPLEMENTED (needs more tests)
• Block
  • New block size rule that discounts signatures/witnesses (BIP0141)
  • Support getting the witness merkle commitment for a block (BIP0141)

Bitcore P2P Library

• New handshake p2p message for "havewitness" sent after "verack" (BIP0144)
• New inventory types for MSG_WITNESS_TX and MSG_WITNESS_BLOCK for getdata messages (BIP0144)

[braydonf]

Work in progress branch: https://github.com/braydonf/bitcore-lib/tree/segwit

[braydonf]

Implemented at branch https://github.com/braydonf/bitcore-lib/tree/segwit in braydonf@6e800e3:

• Witness transaction serialization format and hash
• Witness sighash
• Nested p2sh multisig witness transaction signing
• Segnet network

[braydonf]

Signed tx https://segnet.smartbit.com.au/tx/cac2029d9269c79c4923df11abd7e261f04d8be1f39376c5081abe06596cd205 from Transaction.sign test.

[dabura667]

Suggestion:

Change the default toAddress() for single sig newly generated keys to be P2SH( WPKH ).

So looking at this example:
http://n.bitcoin.ninja/checktx?txid=8139979112e894a14f8370438a471d23984061ff83a9eba0bc7a34433327ec21

pubkeyHex = "038262a6c6cec93c2d3ecd6c6072efea86d02ff8e3328bbd0242b20af3425990ac"
      hash160Hex = "1d7cd6c75c2e86f4cbf98eaed221b30bd9a0b928" (for "1" address)
redeemScript = "00141d7cd6c75c2e86f4cbf98eaed221b30bd9a0b928"
               (segwit 0x00 + serialized push of hash160)

Then run that redeemscript through P2SH as default.

This way people will by default be creating addresses to send to segwit p2sh, encouraging usage.

Also, checking balance for keys (is there a function for that?) should check this p2sh by default for segwit.

[h0jeZvgoxFepBQ2C]

Any progress on this?

[braydonf]

@lichtamberg See #50

[h0jeZvgoxFepBQ2C]

@braydonf thanks.. But it's not really clear what this means :D Is there any ETA when segwit will be fully implemented?

[afk11]

It's been pending work so you can sign all the other scripts in P2WSH + P2SH|P2WSH. I really looks like this project has been deprioritized. Try running bitcore (with bitcoind) on testnet!