Skip to content
This repository was archived by the owner on Apr 3, 2019. It is now read-only.

Add support for bare multisig#12

Merged
braydonf merged 7 commits intobitpay:masterfrom
rubensayshi:bare-multisig
Nov 9, 2015
Merged

Add support for bare multisig#12
braydonf merged 7 commits intobitpay:masterfrom
rubensayshi:bare-multisig

Conversation

@rubensayshi
Copy link
Copy Markdown
Contributor

code is more or less copy paste of P2SH multisig code with some changes.

also added normalizeSignatures to take existing signatures (as buffer, from a partially signed TX for example) and turn them into TransactionSignature instances, not sure what a good name would be, don't think normalizeSignatures is...

Comment thread lib/transaction/input/multisig.js Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would the estimated size include the public keys? Here is an example created with this code: https://test-insight.bitpay.com/tx/dd387bbdeaef66f25b1f1c876df98b1fc6fba62226c01af377800df820bfd338:

<Script: OP_0 72 0x3045022100e633c8ccafde4e3031ea5ced9666336b289f8cf64b6045a879afbd994b824fb502203d16d700e3efd0d957d17941c7b06e7050a9a0132b533742d4e016780d5f1d7001 72 0x30450221008f5dc4a27804b98f00cac764c05b026e49998e7ad469061fd67dc58ecb353acb022012f4b9be8d2a8bf03eed1d01a50c1891d6e691c4f19e9bca7227d8515a4db90901>

And it looks like there are only signatures.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take a look at it and add a test for it and make sure it works properly

@braydonf
Copy link
Copy Markdown
Contributor

braydonf commented Nov 4, 2015

Went through and tested the full process from sending to a multisig output and then signing it, and looks to be working properly.

Looks like there may be some issues regarding the insight-ui display of these inputs/outputs, however unrelated to this PR.

@rubensayshi
Copy link
Copy Markdown
Contributor Author

ugh somehow didnt see your comments earlier ...

@rubensayshi
Copy link
Copy Markdown
Contributor Author

fixed _estimateSize() and updated test

@braydonf
Copy link
Copy Markdown
Contributor

braydonf commented Nov 6, 2015

LGTM

1 similar comment
@matiu
Copy link
Copy Markdown
Contributor

matiu commented Nov 6, 2015

LGTM

@robby-d
Copy link
Copy Markdown

robby-d commented Nov 9, 2015

+1 - counterparty (counterwallet) will make good use of this feature. Looking forward to having it merged.

braydonf added a commit that referenced this pull request Nov 9, 2015
@braydonf braydonf merged commit c6c9021 into bitpay:master Nov 9, 2015
@rubensayshi
Copy link
Copy Markdown
Contributor Author

awesome!

@braydonf will there be a tagged release soon with this?

@braydonf
Copy link
Copy Markdown
Contributor

Landed in 0.13.10

osagga pushed a commit to osagga/bitcore-lib that referenced this pull request Sep 26, 2018
Added confirmations attribute to Transaction.UnspentOutput
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants