This repository was archived by the owner on Apr 3, 2019. It is now read-only.
Fixing segwit transactions #133
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
FWIW, serialization support is already included in #50 |
Author
|
Ha, so I didn't need to write that at all 🤣 Thanks! OK, I will try how your version works. (I am running the bitcore against 0.14.0 - see bitpay/bitcoin#43 ) |
Author
|
...yep, it works, and it seems well written and tested. So ignore this PR then, closing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing segwit transactions, so bitcore can properly parse blocks and transactions with segwit.
It's relevant only if you use it with new bitcoind, but it's also necessary if you use it with new bitcoind. :)
edit: I have now force-pushed satoshilabs:master to have braydonf:segwit commits on top of bitpay:master, so this PR no longer makes sense.