Skip to content

Added compilation support for Node.js v4#348

Merged
pnagurny merged 12 commits intobitpay:masterfrom
braydonf:node-v4
Oct 29, 2015
Merged

Added compilation support for Node.js v4#348
pnagurny merged 12 commits intobitpay:masterfrom
braydonf:node-v4

Conversation

@braydonf
Copy link
Copy Markdown
Contributor

Closes: bitpay/bitcore#1361
Closes: #259

@braydonf braydonf force-pushed the node-v4 branch 4 times, most recently from cd4271b to 101250e Compare October 28, 2015 16:42
Comment thread etc/bitcoin.patch Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a stray space here? I can't tell exactly.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove it, there is a space there.

@kleetus
Copy link
Copy Markdown
Contributor

kleetus commented Oct 29, 2015

this worked ok on debian jesse, but on Mac 10.10, it get:

module.js:339
throw err;
^

Error: Cannot find module 'db/package.json'
at Function.Module._resolveFilename (module.js:337:15)
at Function.Module._load (module.js:287:25)
at Module.require (module.js:366:17)
at require (module.js:385:17)
at Function.setupServices (/Users/chrisk/source/zzbitcore_node/lib/scaffold/start.js:51:30)
at start (/Users/chrisk/source/zzbitcore_node/lib/scaffold/start.js:203:31)
at Object. (/Users/chrisk/source/zzbitcore_node/bin/start.js:8:1)
at Module._compile (module.js:435:26)
at Object.Module._extensions..js (module.js:442:10)
at Module.load (module.js:356:32)

when running:

node bin/start

node 4.2.1

@braydonf
Copy link
Copy Markdown
Contributor Author

I don't think bin/start is supported anymore.
Edit: Working here, that issue may not be related.

@kleetus
Copy link
Copy Markdown
Contributor

kleetus commented Oct 29, 2015

works using ./bin/bitcore start and removing insight related plugins from bitcore-node.json

@kleetus
Copy link
Copy Markdown
Contributor

kleetus commented Oct 29, 2015

LGTM

@pnagurny
Copy link
Copy Markdown
Contributor

tested - works locally. LGTM

pnagurny added a commit that referenced this pull request Oct 29, 2015
Added compilation support for Node.js v4
@pnagurny pnagurny merged commit 275a0b5 into bitpay:master Oct 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants