Optimized address service mempool index size#352
Merged
pnagurny merged 9 commits intobitpay:masterfrom Nov 3, 2015
Merged
Conversation
added 4 commits
October 30, 2015 18:36
- Adds default to store a large portion of the mempool index in leveldb - Includes an option to use memdown to have the mempool index in-memory
Replaced with using `tx` and `txleave` to manage the state of the mempool indexes.
Contributor
|
LGTM |
Contributor
There was a problem hiding this comment.
would be nice not to have these prefixes hardcoded
Contributor
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
Right, instead of having to write this same code block multiple times, it could be DRY'ed up. Not a show stopper, we can clean it up later.
Contributor
There was a problem hiding this comment.
The prefixes I was talking about were {livenet: '', testnet: 'testnet3', regtest: 'regtest'}.
Contributor
Author
There was a problem hiding this comment.
Since there is some shared code, it could be useful to have this.node.networks.getBaseDataDir() or at least a utility function on node, we can spawn an issue and add it in later, since this should also touch the db.js code.
Contributor
|
LGTM |
pnagurny
added a commit
that referenced
this pull request
Nov 3, 2015
Optimized address service mempool index size
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #324
New features:
mempoolSpentIndexhas been kept to be memory only and the key will be 37 bytestxandtxleaveevents from bitcoind and will nolonger make an expensive query for all transactions in the mempoolIncludes breaking API changes:
resetMempoolIndexmethod have been removedrunAllMempoolIndexeshas been removed