Skip to content

Improvements Coinbase integration#11892

Merged
Gamboster merged 4 commits intobitpay:masterfrom
cmgustavo:bug/coinbase-m-01
Sep 27, 2021
Merged

Improvements Coinbase integration#11892
Gamboster merged 4 commits intobitpay:masterfrom
cmgustavo:bug/coinbase-m-01

Conversation

@cmgustavo
Copy link
Member

@cmgustavo cmgustavo commented Sep 22, 2021

@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #11892 (7d558a1) into master (b3bb41a) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11892      +/-   ##
==========================================
- Coverage   28.64%   28.59%   -0.06%     
==========================================
  Files         245      245              
  Lines       22025    22065      +40     
  Branches     3573     3584      +11     
==========================================
  Hits         6310     6310              
- Misses      15161    15201      +40     
  Partials      554      554              
Impacted Files Coverage Δ
...bitpay-card/bitpay-card-topup/bitpay-card-topup.ts 6.09% <ø> (ø)
...ions/coinbase/coinbase-account/coinbase-account.ts 16.16% <0.00%> (-2.23%) ⬇️
...ns/coinbase/coinbase-settings/coinbase-settings.ts 27.27% <0.00%> (-1.76%) ⬇️
...ns/coinbase/coinbase-withdraw/coinbase-withdraw.ts 17.24% <0.00%> (-0.41%) ⬇️
...rds/confirm-card-purchase/confirm-card-purchase.ts 8.18% <ø> (ø)
src/pages/send/confirm/confirm.ts 22.89% <ø> (ø)
src/providers/coinbase/coinbase.ts 8.56% <0.00%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3bb41a...7d558a1. Read the comment docs.

@cmgustavo cmgustavo changed the title WIP Ref Coinbase integration. Improved error handler Improvements Coinbase integration Sep 22, 2021
Copy link
Collaborator

@Gamboster Gamboster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gamboster Gamboster merged commit 01a0ed4 into bitpay:master Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants