Fix fluctuating home balance#11899
Merged
cmgustavo merged 2 commits intobitpay:masterfrom Sep 27, 2021
Merged
Conversation
…ts call (rather than just wallets of a specific coin)
Codecov Report
@@ Coverage Diff @@
## master #11899 +/- ##
==========================================
- Coverage 28.63% 28.63% -0.01%
==========================================
Files 244 244
Lines 21977 21978 +1
Branches 3551 3552 +1
==========================================
Hits 6293 6293
- Misses 15137 15138 +1
Partials 547 547
Continue to review full report at Codecov.
|
msalcala11
force-pushed
the
fix-fluctuating-home-balance
branch
from
132c8f6 to
dd12462
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incoming blocks are currently triggering an "update home balance" calculation, but this calculation only includes wallets that match the currency of the incoming block (resulting in an incorrect total balance shown on the home tab). This PR prevents incorrect home balance calculations by ensuring that the home balance only updates when all wallets (of all currencies) are included in the total balance calculation.