Skip to content

[REF] better messaging and mandatory backup if key is encrypted#12020

Merged
cmgustavo merged 1 commit intobitpay:masterfrom
gabrielbazan7:ref/encrypt
Mar 31, 2022
Merged

[REF] better messaging and mandatory backup if key is encrypted#12020
cmgustavo merged 1 commit intobitpay:masterfrom
gabrielbazan7:ref/encrypt

Conversation

@gabrielbazan7
Copy link
Collaborator

@gabrielbazan7 gabrielbazan7 commented Mar 31, 2022

  • warning when setting encrypt password
  • mandatory backup game if key is encrypted
  • change info icon for warning icon for encrypt option on settings

BitPay

@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #12020 (550ae47) into master (a83a047) will increase coverage by 0.00%.
The diff coverage is 27.77%.

@@           Coverage Diff           @@
##           master   #12020   +/-   ##
=======================================
  Coverage   28.29%   28.29%           
=======================================
  Files         246      246           
  Lines       22487    22501   +14     
  Branches     3688     3688           
=======================================
+ Hits         6362     6366    +4     
- Misses      15545    15555   +10     
  Partials      580      580           
Impacted Files Coverage Δ
src/pages/add/select-currency/select-currency.ts 10.74% <0.00%> (-0.19%) ⬇️
src/pages/onboarding/recovery-key/recovery-key.ts 23.33% <0.00%> (-0.81%) ⬇️
...rc/components/encrypt-password/encrypt-password.ts 51.11% <41.66%> (-4.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a83a047...550ae47. Read the comment docs.

Copy link
Member

@cmgustavo cmgustavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK! 👍🏼

@cmgustavo cmgustavo merged commit b84eedf into bitpay:master Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants