Merged
Conversation
…lated ReferenceSettings tests.
…ls to ReferenceSettings w/o the tests failing...
…splayed on the WebClient.
… will default to 'N/A' and 'Unknown' respectively if the value is Null, i.e. the PillarID doesn't have an entry in the PillaIntegrityDetails in ReferenceSettings.
Bohlski
requested changes
Jun 16, 2022
Contributor
There was a problem hiding this comment.
The quickstart's ReferenceSettings.xml (bitrepository-integration/src/main/resources/quickstart/conf/integrityservice/ReferenceSettings.xml) needs to be updated with the new hostname/pillar type settings - the quickstart throws a null pointer when trying to view integrity status in the GUI right now.
As mentioned in a comment, I also think it would be preferable if the new settings were located under ReferenceSettings' <IntegrityServiceSettings> - it is after all only something to be used by integrity service.
Everything else looks good to me! :)
Member
Author
|
Requests have been updated in the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.