Merged
Conversation
Bohlski
reviewed
Jun 24, 2022
| <td>${j[i].fileID}</td> | ||
| <td>${j[i].alarmCode}</td> | ||
| <td>${nl2br(j[i].alarmText)}</td> | ||
| </tr>`; |
Contributor
|
It also looks good and right to me. And I also do not know how to test it better. |
ole-v-v
approved these changes
Jul 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileID is now a column under Alarm in the WebGUI.
This information is being pulled from the WebAlarm class, that gets it from the AlarmDatabase.
I have tested that the column is present on the WebGUI, but I am unsure how to ingest a fake alarm, to test that the FileID will actually be shown.