Merged
Conversation
… the checksum algorithm or the hexstring wwas incorrect. Now it will return an easily readable message that tells the user what is wrong.
Bohlski
requested changes
Aug 2, 2022
Contributor
Bohlski
left a comment
Bohlski
left a comment
There was a problem hiding this comment.
Don't really know what's the correct way of going about the fact that throwing exceptions seems favorable in some places, while it doesn't for the commandline client. I'm almost leaning to having a separate implementation for checking valid commandline checksums, so it doesn't conflict with the backend part of encoding checksums.
m-atlantis
changed the title
Bohlski
approved these changes
Aug 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed exceptions being thrown if the commandline client arguments for the checksum algorithm or the hex-string was incorrect. Now it will return an easily readable message that tells the user what is wrong.
Also fixed a few other messages to be formatted in a more pretty way.