Conversation
…over the old ones in milliseconds
m-atlantis
requested changes
Aug 1, 2022
Member
m-atlantis
left a comment
m-atlantis
left a comment
There was a problem hiding this comment.
Apart from the one comment about TODO, the code looks fine, BUT the commit could not be build, there is an error when maven tries to build the project
m-atlantis
approved these changes
Aug 1, 2022
Bohlski
reviewed
Aug 1, 2022
Member
|
The build still doesn't compile, how does it look locally when you perform maven build? |
Contributor
|
@m-atlantis It doesn't compile because the newest rendition of repository-settings 14-SNAPSHOT is not up on Nexus. Either way the snapshot-version should not be used, so it wouldn't be able to build before a new release of repository-settings is made. |
…readable settings
Bohlski
requested changes
Aug 29, 2022
Contributor
Bohlski
left a comment
Bohlski
left a comment
There was a problem hiding this comment.
Looks like I again had posted comments without actually finishing the review, so they could be seen by others..
Overall happy with the changes though 👍
Bohlski
approved these changes
Sep 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the changes to repository-settings the reference projects have been updated to use the new settings IdentificationTimeoutDuration and OperationTimeoutDuration and to prefer them over the old ones IdentificationTimeout and OperationTimeout. The old ones still work (for a transitional period) if the new ones are not set.
Please review. Please also help me consider how I should test the changes.
The reference settings have not been touched yet. They will be.
Link: https://sbforge.org/jira/browse/BITMAG-992