Conversation
…llar integrity status. This new Pager shows a list of all files and on which pillars it can be found, aka. it is an overview.
…e instead of having its own row. Also introduced a search-bar in the modal.
…r position on the page, when the table is scrolled through.
…n if there are no results upon searching for a file ID.
… server that works.
…y status does not contain a link to a modal if there is no integrity report for the given state. I.e. no link if there is no missing files on any pillar.
ole-v-v
approved these changes
Aug 3, 2022
Member
Author
|
Fixed the issues and have re-requested a review |
Bohlski
requested changes
Aug 15, 2022
Contributor
Bohlski
left a comment
Bohlski
left a comment
There was a problem hiding this comment.
Looks good (except the stuff that didn't work :P), but I'm not sure I agree with removing paging from the REST endpoints completely.
Perhaps it could be fine for checksum errors etc. to just all be grabbed in one go, but calling the getAllFileIDs endpoint on a bitrepository in production could possibly result in many millions of file IDs being returned, which I'm not convinced wouldn't be very slow. As I see it, there was a reason why paging was being done in the first place - but I definitely also think that there should be an option to get all IDs.
…ong values if no files were found.
ole-v-v
approved these changes
Aug 17, 2022
Bohlski
requested changes
Aug 18, 2022
Bohlski
requested changes
Aug 25, 2022
Contributor
Bohlski
left a comment
Bohlski
left a comment
There was a problem hiding this comment.
Looking good. There was a small change I imagine was accidentally committed that made modals not work, but I fixed it in the merge that I'll push following this.
Bohlski
approved these changes
Aug 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.