BITMAG-1125 & BITMAG-1139: FileExchange protocol handling#49
Merged
m-atlantis merged 6 commits intomasterfrom Jan 4, 2023
Merged
BITMAG-1125 & BITMAG-1139: FileExchange protocol handling#49m-atlantis merged 6 commits intomasterfrom
m-atlantis merged 6 commits intomasterfrom
Conversation
Also removed FileExchange as StorageModel-param and fixed few typos etc.
I.e. FileExchange is no longer provided as a parameter to ContributorContext (and inheriting classes), but instead dynamically instantiated at time of use with FileExchangeResolver. This allows pillars to not bind themselves to a specific file exchange, but dynamically handle the provided url protocol.
Bohlski
changed the title
m-atlantis
requested changes
Nov 10, 2022
Member
m-atlantis
left a comment
m-atlantis
left a comment
There was a problem hiding this comment.
Looking for some clarification, looking good though
m-atlantis
approved these changes
Jan 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BITMAG-1125
BITMAG-1139