Add IM placement codes and fluent option builders (#437)#438
Merged
Conversation
…422) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds first-class support for Bitrix24 IM widget placements under the new
Bitrix24\SDK\Services\IM\Placementsnamespace:PlacementLocationCodes— public constants for the four IM placement codes:IM_TEXTAREA,IM_SIDEBAR,IM_CONTEXT_MENU, and the deprecated-since-im 25.1600.0IM_SMILES_SELECTOR.PlacementOptionsInterfacewithbuild(): array— contract for any objectthat produces the
OPTIONSpayload forplacement.bind.AbstractPlacementOptions— shared fluent base providingcontext(),role(),and
extranet()setters, backed by the string-backed enumsChatContext,Role,and
ExtranetAvailability. Multi-valuecontext()joins with;per API contract.TextareaPlacementOptions— requirediconName, pluscolor(),width(),height().SidebarPlacementOptions— requirediconName, pluscolor().ContextMenuPlacementOptions— only the shared base setters.PlacementColor— string-backed enum covering all 17 documented colors.The
Placement::bind()service method now acceptsPlacementOptionsInterface|arrayfor its
$optionsargument. Passing a builder normalizes tobuild()internally;existing array callers remain fully compatible — this is a pure type widening,
not a breaking change.
Usage
Quality gate
make lint-cs-fixer— greenmake lint-rector— greenmake lint-phpstan— greenmake lint-deptrac— green (no new violations)make test-unit— 766 tests, 1957 assertions passNotes
Serviceslayer; depends only onCoretransitively — no newarchitectural boundary crossings.
PlacementLocationCodesintentionally remains a plain class withpublic const(not anenum) so that the deprecated
IM_SMILES_SELECTORconstant can carry a@deprecatedPHPDoc without the friction of enum-case deprecation.
chaining returns
$this.Closes #437