Add IM\Dialog service for im.dialog.* support#451
Merged
Conversation
16 tasks
…prove error handling docs - Ensure `Core::call()` routes array-structured 401 errors through `ApiLevelErrorHandler`. - Add `bitrix_rest_v3_exception_accessdeniedexception` to `ApiLevelErrorHandler` cases. - Update tests to cover v3 unauthorized error handling. - Document typing for date/time arguments and API metadata link standards. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
…able` for improved type safety Signed-off-by: mesilov <mesilov.maxim@gmail.com>
…g.get` in ResultItem pipeline - Introduced `.tasks/425/im.dialog.get/result-item.payload.yaml` for defining canonical payloads. - Added `.tasks/425/im.dialog.get/result-item.verification-report.yaml` for API verification results. - Updated ResultItem pipeline to ensure these files align with Bitrix24 REST standards. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
- Added `ResultItemGeneratorCommand` for managing build, verify, apply, and generate stages of ResultItem pipelines. - Introduced `DefaultResultItemGeneratorWorkflow` for handling OpenAPI and REST docs payload generation and validation. - Added unit tests to validate pipeline stages and workflow logic. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
…` with runtime field type casting - Added `AbstractAnnotatedItem` with Typhoon-based runtime type casting for annotated fields. - Updated `DialogItemResult` to extend `AbstractAnnotatedItem` for PHPDoc-based type casting of magic getters. - Added unit tests to verify field type casting logic based on annotations. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
…e annotated getters - Added unit and integration tests to validate runtime field type casting in `ContactItemResult`. - Integrated additional logic for array and user field handling in annotated getters. - Defined workflow for testing edge cases like nullable fields and smart process item retrieval. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Signed-off-by: mesilov <mesilov.maxim@gmail.com>
…r `DialogTest` - Updated `Factory::getBulkItemsReader` to accept application credentials. - Modified `Factory::getCore` logic to conditionally load application credentials. - Refactored `DialogTest` for better readability and updated imports. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
…ialogItemResult` - Replaced `AbstractItem` references with `AbstractAnnotatedItem` in test cases. - Ensured test coverage aligns with updated class structure and annotations. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
…and update tests - Updated `Dialog::messagesSearch` to use `CarbonImmutable` for date filters, ensuring type safety and proper serialization to REST API format. - Adjusted integration and unit tests to reflect `CarbonImmutable` usage in date handling. - Added `typhoon/reflection` as a runtime dependency due to updates in result-item casting logic. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
…`b24phpsdk-maintainer` - Updated `SKILL.md` to mandate using SDK file generators (`*ItemResult`, `*SelectBuilder`, `*ItemBuilder`) before manual edits. - Added generator usage rules, including dependency on `openapi.json` and testing requirements. - Updated changelog to reflect the new guidelines. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
…adStateItemResult` from REST payloads - Updated `ChatItemResult`, `DialogUserItemResult`, and `DialogReadStateItemResult` to reflect REST docs-based payload shapes. - Migrated from `AbstractItem` to `AbstractAnnotatedItem` for enhanced type annotations and runtime type casting. - Extended SDK generator workflow and added tests to support REST responses for `im.chat.get`, `im.dialog.read`, and `im.dialog.users.list`. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
- Updated `SKILL.md` and `AGENTS.md` to mandate running `make lint-rector` before reporting tasks as completed, including microtasks. - Adjusted guidelines to ensure Rector checks are enforced for all implementation tasks. - Updated changelog to reflect the new requirements. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the new
IM\\Dialogservice and result wrappers for theim.dialog.*scope. The PR wires the service intoIMServiceBuilder, covers the new endpoints with unit and live integration tests, and adds dedicated annotation validation for dialog, message, and dialog-user result items.Test plan
make lint-cs-fixermake lint-rectormake lint-phpstanmake lint-deptracmake test-unitmake test-integration-im-dialogCloses #425