fix: 在使用spring-cloud-kubernetes的时候不会初始化Registration #128#130
Merged
Conversation
cnlkl
reviewed
May 19, 2022
| val filteredInstances = if (loadBalancerProperties.gray.enabled) { | ||
| // 使用k8s的service的时候，应该只有一个endpoint，所以这里只取第一个 | ||
| if (instances.size == 1) { | ||
| return DefaultResponse(instances[0]) |
Contributor
There was a problem hiding this comment.
使用consul的时候，如果instances只有一个，但是与当前服务不在一个灰度环境，这边直接返回会第一个instance会导致调用到不同灰度环境的服务实例
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.