Fixes for x/yValue for inverted charts#66
Merged
pawelfus merged 2 commits intoblacklabel:masterfrom Oct 26, 2016
Merged
Conversation
pawelfus
reviewed
Oct 25, 2016
js/annotations.js
Outdated
| }); | ||
| } else { | ||
| group.translate(x, y); | ||
| setTimeout(function() { |
Collaborator
There was a problem hiding this comment.
Hmm, what exactly does it fix? If chart.animation is disabled, then we do we need to defer group translation?
Author
There was a problem hiding this comment.
series animation can be true even if chart.animation returns false. I think what I need to do here is to do an else if and check if series animation exists and if yes, do a group.animate. I'll remove this commit from this PR and post it via a different PR.
eltonjude
force-pushed
the
fix/bar-chart-xy-value
branch
from
41761f0 to
ee9782a
Compare
Author
|
@pawelfus I have removed commit eltonjude@05e570b from this PR since it had nothing to do with the purpose of this PR in the first place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this example, I want to draw a rectangle in the middle of the first bar, starting at 25px and having a width of 50px.
Existing broken case: http://jsfiddle.net/gnb0pos7/
With the fixes in this PR: http://jsfiddle.net/gnb0pos7/1/
Works fine for column chart with and without these fixes:
Without: http://jsfiddle.net/gnb0pos7/2/
With: http://jsfiddle.net/gnb0pos7/3/