1.2.0#2
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds client-side encryption helpers and integrates them into the extension so stored autologin credentials are encrypted/decrypted when saved/used.
Changes:
- Introduces shared AES-GCM encryption utilities and key persistence in extension storage.
- Encrypts username/password before saving from the popup and decrypts them when loading/using autologin.
- Updates content script/popup script loading and adjusts CI lint workflow trigger behavior.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| script/sharedencryption.js | New shared WebCrypto AES-GCM key management + encrypt/decrypt helpers. |
| script/autologin.js | Decrypts stored credentials (with plaintext fallback). |
| popup/popup.js | Encrypts on save; decrypts on popup load (with plaintext fallback). |
| popup/popup.html | Loads the shared encryption script before popup logic. |
| manifest.json | Ensures shared encryption script loads before autologin content script. |
| .github/workflows/web-ext-lint.yaml | Changes when the lint workflow runs on pushes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add encryption